Without gcp - #401
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Ooooh yes! I like this approach. @haileyok might have thoughts too |
Alright, I'll push more changes to cover the other tiers. |
|
Once #388 lands, I'll modify the gcp checks here to use |
I've created a KafkaPublisher that's used in place of PubSubPublisher when osprey isn't being run on GCP. The published data doesn't have a subscriber/consumer yet, it's just published, the rules visualizer now shows nodes like it should. I need to better handle when an exception is raised in KafkaPublisher.publish. Signed-off-by: Chihurumnaya Ibiam <ibiamchihurumnaya@gmail.com>
This should complete Tier1 of issue roostorg#343 Signed-off-by: Chihurumnaya Ibiam <ibiamchihurumnaya@gmail.com>
This makes it easier for any future subclasses of BasePublisher to work as a return value, so there's no need to explicitly state the return types like I did. Signed-off-by: Chihurumnaya Ibiam <ibiamchihurumnaya@gmail.com>
Signed-off-by: Chihurumnaya Ibiam <ibiamchihurumnaya@gmail.com>
It doesn't require GCS to upload the files to process for the actions as there's a LocalBulkActionFileManager that it defaults to for dev environments. Signed-off-by: Chihurumnaya Ibiam <ibiamchihurumnaya@gmail.com>
2 participants
Description
Make Osprey runnable without GCP credentials.
I've created an alternative to PubSubPublisher using Kafka, so there's a fallback when Osprey isn't running on GCP.
Kafka because Osprey uses it.
@julietshen this is a WIP, I've covered Tier1. Is this the direction you're thinking of heading in?
Checklist
uv run ruff check .passes (no unused imports or other lint errors)uv tool run fawltydeps --check-unused --pyenv .venvpasses (no unused dependencies)CHANGELOG.mdwith my changes, if notable (refer to Keep a Changelog conventions)